[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver
> -----Original Message----- > From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org] On > Behalf Of Paolo Bonzini > Sent: Monday, March 27, 2017 7:34 PM > To: Liu, Changpeng <changpeng.liu@intel.com>; virtio-dev@lists.oasis-open.org; > virtualization@lists.linux-foundation.org; linux-kernel@vger.kernel.org; hch@lst.de > Cc: qemu-devel@nongnu.org > Subject: Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver > > > > On 28/03/2017 10:39, Changpeng Liu wrote: > > + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > > + q->limits.discard_zeroes_data = 0; > > Maybe you could use another feature bit to populate discard_zeroes_data. > > Paolo > Sounds good to me, Christoph Hellwig mentioned this field will be removed in next release, just removed this line makes clear. > > + q->limits.discard_alignment = blk_size; > > + q->limits.discard_granularity = blk_size; > > + blk_queue_max_discard_sectors(q, UINT_MAX); > > + blk_queue_max_discard_segments(q, 1); > > + queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q); > > + } > > + > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]