[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support
> On Feb 27, 2018, at 7:35 AM, David Miller <davem@davemloft.net> wrote: > > I don't like these helpers on many different levels. <snip much embarrassment> > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I completely agree with your comments and wish that I had seen those things myself. > Thanks. V3 was junk, but your comments apply to V4 as well, so please ignore it. Thank you for your valuable review. -- Mark Rustad, Networking Division, Intel Corporation
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]