[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v9 14/16] VIRTIO_F_NOTIFICATION_DATA: extra data to devices
On Wed, 7 Mar 2018 17:10:21 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Wed, Mar 07, 2018 at 03:49:41PM +0100, Cornelia Huck wrote: > > On Wed, 7 Mar 2018 16:09:33 +0200 > > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > > > On Wed, Mar 07, 2018 at 12:11:58PM +0100, Cornelia Huck wrote: > > > > On Thu, 1 Mar 2018 01:31:37 +0200 > > > > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > > > @@ -2340,12 +2455,22 @@ GPR & Input Value & Output Value \\ > > > > > \hline > > > > > 2 & Subchannel ID & Host Cookie \\ > > > > > \hline > > > > > - 3 & Virtqueue number & \\ > > > > > + 3 & Notification data & \\ > > > > > \hline > > > > > 4 & Host Cookie & \\ > > > > > \hline > > > > > \end{tabular} > > > > > > > > > > +When VIRTIO_F_NOTIFICATION_DATA has not been negotiated, > > > > > +the \field{Notification data} includes the Virtqueue number. > > > > > + > > > > > +When VIRTIO_F_NOTIFICATION_DATA has been negotiated, > > > > > +the value has the following format: > > > > > +\lstinputlisting{notifications.c} > > > > > > > > And we probably want to make this be explicitly. > > > > > > Are you sure? > > > I looked at s390 code and it just uses VQ index in native > > > endian-ness, so I kept this consistent. > > > > Native endian is always be on s390. The registers for the hypercall are > > therefore always be. > > Oh I thought there's ppc LE now. ppc is not s390 :) I highly doubt that there will be non-be s390 ever (too much legacy software).
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]