Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

["Samudrala, Sridhar" <sridhar.samudrala@intel.com>]

On 5/7/2018 3:39 PM, Randy Dunlap wrote:
> Hi,
>
> On 05/07/2018 03:10 PM, Sridhar Samudrala wrote:
> > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> > ---
> >   MAINTAINERS                |    7 +
> >   include/linux/netdevice.h  |   16 +
> >   include/net/net_failover.h |   52 +++
> >   net/Kconfig                |   10 +
> >   net/core/Makefile          |    1 +
> >   net/core/net_failover.c    | 1044 ++++++++++++++++++++++++++++++++++++++++++++
> >   6 files changed, 1130 insertions(+)
> >   create mode 100644 include/net/net_failover.h
> >   create mode 100644 net/core/net_failover.c
>
> > diff --git a/net/Kconfig b/net/Kconfig
> > index b62089fb1332..0540856676de 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -429,6 +429,16 @@ config MAY_USE_DEVLINK
> >   config PAGE_POOL
> >          bool
> >   
> > +config NET_FAILOVER
> > +	tristate "Failover interface"
> > +	default m
> Need some justification for default m (as opposed to n).

default n should be fine.  It will get selected automatically when virtio_net or
netvsc are enabled. will fix in the next revision.


>