OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH] split-ring: Fix typo in used ring description


On 05/22/18 21:11, Christoffer Dall wrote:
> Only the device updates the used ring.
> 
> This looks like a typo as a result of copy-paste from the description of
> the Available Ring.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/12
> Signed-off-by: Christoffer Dall <christoffer.dall@arm.com>
> ---
>  split-ring.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/split-ring.tex b/split-ring.tex
> index df278fe..2267863 100644
> --- a/split-ring.tex
> +++ b/split-ring.tex
> @@ -417,7 +417,7 @@ overwritten the bytes which were in that buffer, this could leak the
>  contents of freed memory from other processes to the application.
>  \end{note}
>  
> -\field{idx} field indicates where the driver would put the next descriptor
> +\field{idx} field indicates where the device would put the next descriptor
>  entry in the ring (modulo the queue size). This starts at 0, and increases.
>  
>  \begin{note}
> 

Good point about this likely being a copypasta error; when I first tried
to look at the context of your patch in "split-ring.tex", I found the
*correct* instance (currently on line 308) and got confused. But, the
line numbers in the hunk header above are OK; on line 420, "driver" is
wrong.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]