[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev] [PATCH v3] content: support SR-IOV
On Thu, May 24, 2018 at 06:20:36PM +0300, Michael S. Tsirkin wrote: > On Thu, May 24, 2018 at 11:15:26PM +0800, Tiwei Bie wrote: > > On Thu, May 24, 2018 at 04:44:18PM +0300, Michael S. Tsirkin wrote: > > > On Thu, May 24, 2018 at 08:06:41AM +0800, Tiwei Bie wrote: > > > > On Wed, May 23, 2018 at 10:34:29PM +0300, Michael S. Tsirkin wrote: > > > > > On Wed, May 23, 2018 at 08:54:47PM +0300, Michael S. Tsirkin wrote: > > > > > > On Tue, May 22, 2018 at 06:26:15PM +0800, Tiwei Bie wrote: [...] > > > > > > So my point is this, VFs themselves do not have > > > this feature. > > > > Yeah. I also think VFs shouldn't present this feature. > > > > > > > > Should all of them have it? None of them? > > > I don't see what use it is to VFs, but maybe > > > we will come with a use down the road. > > > > > > I propose we require that > > > 1. drivers ignore this if there is > > > no SRIOV cap, and > > > > > > 2. that devices do not expose it. > > > > > > This way if we come up with a use down the road, only new drivers > > > will negotiate it. > > > > I got your point now. Thanks! > > > > How about: > > > > If VIRTIO_F_SR_IOV has been negotiated, a driver can enable > > virtual functions through the device's PCI SR-IOV capability > > structure. A driver MUST NOT negotiate VIRTIO_F_SR_IOV if > > the device does not have a PCI SR-IOV capability structure > > or is not a PCI device. A driver MUST negotiate > > VIRTIO_F_SR_IOV and complete the feature negotiation > > (including setting the DRIVER_OK \field{status} bit) before > > enabling virtual functions through the device's PCI SR-IOV > > capability structure. > > Sounds good. > [...] > > > > > > Assuming we teach drivers they should ignore it > > > if it is there without SRIOV, then this last one I'd make MUST NOT. > > > > Okay, how about > > > > A device SHOULD offer VIRTIO_F_SR_IOV if it is a PCI > > device and presents a PCI SR-IOV capability structure, > > otherwise it MUST NOT offer VIRTIO_F_SR_IOV. > > > > Best regards, > > Tiwei Bie > > Sounds good. Thanks a lot! I'll send a new version. Best regards, Tiwei Bie
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]