[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v3] content: enhance device requirements for feature bits
On Mon, Jun 11, 2018 at 03:56:40PM +0800, Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > --- > v2: > - Refine the wording (Cornelia); > > v3: > - Refine the wording (MST); > > content.tex | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/content.tex b/content.tex > index f996fad..3c7d67d 100644 > --- a/content.tex > +++ b/content.tex > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset > of features the driver accepts, otherwise it MUST fail to set the > FEATURES_OK \field{device status} bit when the driver writes it. > > +If a device has successfully negotiated a set of features > +at least once (by accepting the FEATURES_OK \field{device > +status} bit during device initialization), then it SHOULD > +NOT fail re-negotiation of the same set of features after > +a device or system reset. Failure to do so would interfere > +with resuming from suspend and error recovery. > + > \subsection{Legacy Interface: A Note on Feature > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature > Bits / Legacy Interface: A Note on Feature Bits} OK but there's no \field{device status} anywhere else I think. We only have \field{status} in spec. > -- > 2.17.0
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]