Re: [virtio-dev] [PATCH] virtio-blk: clarify semantics of multi-segment discard/write zeroes commands

[Cornelia Huck <cohuck@redhat.com>]

On Tue, 26 Feb 2019 18:09:03 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> On Tue, 26 Feb 2019 16:25:53 +0000
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> > Describe the failure case and maximum number of segments in a
> > multi-segment discard/write zeroes command.
> > 
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/34
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > I would like to request a vote on this.  
> 
> Only one minor nit from me, below.
> 
> > 
> >  content.tex | 23 +++++++++++++++++++++--
> >  1 file changed, 21 insertions(+), 2 deletions(-)
> > 
> > diff --git a/content.tex b/content.tex
> > index c5fdc34..7bfcc78 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3967,8 +3967,10 @@ read from the block device (in multiples of 512 bytes).  VIRTIO_BLK_T_OUT
> >  requests write the contents of \field{data} to the block device (in multiples
> >  of 512 bytes).
> >  
> > -The \field{data} used for discard or write zeroes command is described
> > -by one or more virtio_blk_discard_write_zeroes structs:
> > +The \field{data} used for discard or write zeroes commands consists of one or
> > +more segments.  The maximum number of segments is \field{max_discard_seg} for
> > +discard commands and \field{max_write_zeroes_seg} for write zeroes commands.
> > +Each segment is of form:  
> 
> Maybe s/of form/of the form/ ?

...and that is certainly a non-material change we could do on top.