Re: [virtio-dev] [PATCH v3] Add virtio-iommu device specification

[Jean-Philippe Brucker <jean-philippe.brucker@arm.com>]

On 03/05/2019 20:47, Michael S. Tsirkin wrote:
> On Tue, Apr 30, 2019 at 03:42:14PM +0100, Jean-Philippe Brucker wrote:
>> On 30/04/2019 14:56, Jean-Philippe Brucker wrote:
>> > The IOMMU device allows a guest to manage DMA mappings for physical,
>> > emulated and paravirtualized endpoints. Add device description for the
>> > virtio-iommu device and driver. Introduce PROBE, ATTACH, DETACH, MAP and
>> > UNMAP requests, as well as translation error reporting.
>> > 
>> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/37
>> > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>> 
>> I'd like to request a vote for this version (the github issue is now up
>> to date and the patch applies cleanly)
>> 
>> Thanks,
>> Jean
> 
> I sent some comments that might be worth addressing before the vote.  If
> you don't agree I'm fine with starting voting now if you like and we'll
> let the TC decide, pls let me know.

Thanks for the review, I agree with most comments. I'll reply this week
and then send a new version, so you can hold off the vote

Thanks,
Jean