Re: [virtio-dev] [PATCH] virtio-gpu: add shared resource feature

[Matti Moell <Matti.Moell@opensynergy.com>]

Hi Gerd,

I really like this!

On 28.11.19 14:19, Gerd Hoffmann wrote:
> @@ -186,6 +211,7 @@ \subsubsection{Device Operation: Request header}\label{sec:Device Types / GPU De
>           VIRTIO_GPU_CMD_GET_CAPSET_INFO,
>           VIRTIO_GPU_CMD_GET_CAPSET,
>           VIRTIO_GPU_CMD_GET_EDID,
> +        VIRTIO_GPU_CMD_RESOURCE_CREATE_2D_SHARED,
Shouldn't there also the RESOURCE_CREATE_3D_SHARED? I know that 3D isn't 
speced here but it looks awkward not to reserve it.

>   
>           /* cursor commands */
>           VIRTIO_GPU_CMD_UPDATE_CURSOR = 0x0300,
> @@ -205,6 +231,7 @@ \subsubsection{Device Operation: Request header}\label{sec:Device Types / GPU De
>           VIRTIO_GPU_RESP_ERR_INVALID_RESOURCE_ID,
>           VIRTIO_GPU_RESP_ERR_INVALID_CONTEXT_ID,
>           VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER,
> +        VIRTIO_GPU_RESP_ERR_NO_BACKING_STORAGE,
>   };
>   
>   #define VIRTIO_GPU_FLAG_FENCE (1 << 0)

Cheers,

		Matti