[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources
> +\begin{lstlisting} > +struct virtio_gpu_export_resource { > + struct virtio_gpu_ctrl_hdr hdr; > + le32 resource_id; > + le32 padding; > +}; > + > +struct virtio_gpu_resp_export_resource { > + struct virtio_gpu_ctrl_hdr hdr; > + le64 uuid_low; > + le64 uuid_high; > +}; > +\end{lstlisting} Is there a specific reason why you want the host pick the uuid? I would let the guest define the uuid, i.e. move the uuid fields to virtio_gpu_export_resource and scratch virtio_gpu_resp_export_resource. Also I'd siggest to name the command (and struct) RESOURCE_ASSIGN_UUID. cheers, Gerd
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]