[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev] Re: [PATCH 1/2] virtio: add dma-buf support for exported objects
On Tue, Feb 25, 2020 at 3:10 PM Gerd Hoffmann <kraxel@redhat.com> wrote: > > On Wed, Feb 19, 2020 at 05:06:36PM +0900, David Stevens wrote: > > This change adds a new flavor of dma-bufs that can be used by virtio > > drivers to share exported objects. A virtio dma-buf can be queried by > > virtio drivers to obtain the UUID which identifies the underlying > > exported object. > > That duplicates a bunch of code from dma-buf.c in virtio_dma_buf.c. > > How about dma_buf_{get,set}_uuid, simliar to dma_buf_set_name? While I'm not opposed to such an API, I'm also hesitant to make changes to the dma-buf API for a single use case. As for the duplicated code around virtio_dma_buf_export_info, it can be removed by sacrificing a little bit of type safety, if that's preferable. -David
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]