Re: [PATCH v7] virtio-snd: add virtio sound device specification

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> 2. Rework jack configuration structure, now it's more aligned with the HDA spec.

Yep, that looks good.

> +\item[\field{hda_fn_nid}] indicates a functional node identifier
> +(see \hyperref[intro:HDA]{HDA}, section 7.1.2).

How is the nid used?

In general some of the defconf and caps fields might need some
clarification if and how they are used, given we just cherry-pick
some items from the HDA spec ...

> +\item[\field{hda_reg_caps}] indicates a pin capabilities value
> +(see \hyperref[intro:HDA]{HDA}, section 7.3.4.9).

... for example:

If the "Presence Detect Capable" bit is set the status is available in
the "connected" field.

"VRef Control" is not supported and must be zero.

> +\item[\field{connected}] indicates the current jack connection status
> +(1 - connected, 0 - disconnected).

cheers,
  Gerd