Re: [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding

[Auger Eric <eric.auger@redhat.com>]

Hi jean,
On 3/23/20 2:20 PM, Jean-Philippe Brucker wrote:
> This reference to 'padding' is a leftover from a previous draft of the
> virtio-iommu device. The field doesn't exist anymore, remove the
> requirement.
> 
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> I just noticed this was still here, sorry for the delay. Previous
> discussion:
> https://lists.oasis-open.org/archives/virtio-dev/201911/msg00084.html
> ---
>  virtio-iommu.tex | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/virtio-iommu.tex b/virtio-iommu.tex
> index 28c562b..08b358a 100644
> --- a/virtio-iommu.tex
> +++ b/virtio-iommu.tex
> @@ -106,8 +106,6 @@ \subsection{Device configuration layout}\label{sec:Device Types / IOMMU Device /
>  
>  \devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
>  
> -The device SHOULD set \field{padding} to zero.
> -
>  The device MUST set at least one bit in \field{page_size_mask}, describing
>  the page granularity. The device MAY set more than one bit in
>  \field{page_size_mask}.
> 
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric