[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'
On Mon, Apr 27, 2020 at 8:11 AM David Hildenbrand <david@redhat.com> wrote: > > On 27.04.20 17:08, Alexander Duyck wrote: > > On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand <david@redhat.com> wrote: > >> > >> There is only one wrong comment remaining I think. Something like > >> > >> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > >> index a1d6fb52c8..1b2127c04c 100644 > >> --- a/hw/virtio/virtio-balloon.c > >> +++ b/hw/virtio/virtio-balloon.c > >> @@ -554,8 +554,8 @@ static void virtio_balloon_free_page_stop(VirtIOBalloon *s) > >> */ > >> qemu_mutex_lock(&s->free_page_lock); > >> /* > >> - * The guest hasn't done the reporting, so host sends a notification > >> - * to the guest to actively stop the reporting. > >> + * The guest isn't done with hinting, so the host sends a notification > >> + * to the guest to actively stop the hinting. > > > > I'll probably tweak it slightly and drop the "with". So the comment will read: > > /* > > * The guest isn't done hinting, so host sends a notification > > I always feel like "so host sends" sounds wrong ("the host"). But I am > not a native speaker. Actually it might read better to get rid of "the host" entirely to make it more of an imperative statement rather than a declarative one. Maybe something more like: /* * The guest isn't done hinting, so send a notification * to the guest to actively stop the hinting. */
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]