Re: [virtio-dev] [PATCH v5 02/10] vhost-user: minor fixes

[Alex BennÃe <alex.bennee@linaro.org>]

Nikos Dragazis <ndragazis@arrikto.com> writes:

> Signed-off-by: Nikos Dragazis <ndragazis@arrikto.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  virtio-vhost-user.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virtio-vhost-user.tex b/virtio-vhost-user.tex
> index ac96dc2..13ecd41 100644
> --- a/virtio-vhost-user.tex
> +++ b/virtio-vhost-user.tex
> @@ -231,7 +231,7 @@ \subsubsection{Doorbell structure layout}\label{sec:Device Types / Vhost-user De
>  \end{lstlisting}
>  
>  The \field{cap.offset} and \field{doorbell_off_multiplier} are taken from the
> -notification capability structure above, and the \field{doorbell_idx} is the
> +doorbell capability structure above, and the \field{doorbell_idx} is the
>  doorbell number.

I think it would be helpful to add what we mean by doorbell and
notification into the terminology section at the front of the document?

>  
>  \devicenormative{\paragraph}{Doorbell capability}{Device Types / Vhost-user Device Backend / Additional Device Resources over PCI / Doorbell capability}
> @@ -260,7 +260,7 @@ \subsubsection{Notification structure layout}\label{sec:Device Types / Vhost-use
>  notification interrupts.  If MSI-X is not available, bit 2 of the ISR status
>  indicates that a notification occurred.
>  
> -The notification structure is found using the VIRTIO_PCI_CAP_DOORBELL_CFG
> +The notification structure is found using the VIRTIO_PCI_CAP_NOTIFICATION_CFG
>  capability.
>  
>  \begin{lstlisting}


-- 
Alex BennÃe