OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-dev] [PATCH v5 01/10] vhost-user: add vhost-user device type


Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Thu, Jul 16, 2020 at 05:45:47PM +0100, Alex BennÃe wrote:
>> Nikos Dragazis <ndragazis@arrikto.com> writes:
<snip>
>> 
>> OK stuff is disappearing in later patches. Maybe it shouldn't be
>> introduced in the first place?
>
> I think Nikos sent the patches in this order to keep my authorship.
>
> Nikos: Feel free to squash everything into one patch and add your
> Signed-off-by. You can also set yourself as the author of the git
> commit. As long as my Signed-off-by stays on the patch it indicates I
> have given permission to use this text.

FWIW I think building up a document in discreet patches is still
worthwhile from an ease of review and following the "story" of a feature
development - just that if blocks of text are deleted later in that
story you might as well squash those deletions into the earlier patch.

-- 
Alex BennÃe


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]