OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: [PATCH] virtio-net: fix speed, duplex

Speed values have an extra "f" - they are 32 bit, not 36 bit.  Duplex is
implemented in Linux and QEMU as 0x01 for full duplex and 0x00 for half

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/75
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/content.tex b/content.tex
index bc26674..47a4c6a 100644
--- a/content.tex
+++ b/content.tex
@@ -2994,9 +2994,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
 exist if VIRTIO_NET_F_SPEED_DUPLEX is set.
 \field{speed} contains the device speed, in units of 1 MBit per
-second, 0 to 0x7ffffffff, or 0xfffffffff for unknown speed.
+second, 0 to 0x7fffffff, or 0xffffffff for unknown speed.
-\field{duplex} has the values of 0x00 for full duplex, 0x01 for
+\field{duplex} has the values of 0x01 for full duplex, 0x00 for
 half duplex and 0xff for unknown duplex state.
 Both \field{speed} and \field{duplex} can change, thus the driver

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]