OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH v8 4/3] content: Minor change to clarify free_page_hint_cmd_id


On Mon, 14 Sep 2020 12:44:09 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:

> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> 
> The original wording was a bit unclear and could have been misinterpreted
> as indicating that VIRTIO_BALLOON_FREE_PAGE_HINT was read-only instead of
> the field free_page_hint_cmd_id. To clarify that break it up into two
> sentences making it clear that the field is only available if the feature
> is negotiated, and that the field is read-only.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> 
> So this patch addresses a minor nit that was pointed out after the ballot
> had already been created. If need be I can either open a new bugzilla and
> request a ballot to have it added.
> 
>  content.tex |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/content.tex b/content.tex
> index 76dfce919b97..f74090491534 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -5052,8 +5052,8 @@ \subsection{Device configuration layout}\label{sec:Device Types / Memory Balloon
>    \field{num_pages} and \field{actual} are always available.
>  
>    \field{free_page_hint_cmd_id} is available if
> -    VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated and is read-only by
> -    the driver.
> +    VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated. The field is
> +    read-only by the driver.
>  
>  \begin{lstlisting}
>  struct virtio_balloon_config {
> 
> 

Reviewed-by: Cornelia Huck <cohuck@redhat.com>



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]