[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev] [PATCH] Add lifetime metrics to virtio-blk
On Fri, Feb 19, 2021 at 10:59:26AM -0700, Enrico Granata wrote: Thanks! Minor comments below: > @@ -4648,6 +4653,20 @@ \subsection{Device Operation}\label{sec:Device > Types / Block Device / Device Ope > \field{data}. The device ID string is a NUL-padded ASCII string up to 20 bytes > long. If the string is 20 bytes long then there is no NUL terminator. > > +The \field{data} used for VIRTIO_BLK_T_GET_LIFETIME requests consists of one > +segment which is populated by the device, and is of the form: "consists of one segment" should probably be removed. The framing (layout) of requests is up to the driver (see 2.6.4 Message Framing). struct virtio_blk_lifetime could be a single descriptor, it could be split across multiple descriptors, or it could be combined in a larger descriptor with the virtio-blk request status byte. > + > +\begin{lstlisting} > +struct virtio_blk_lifetime { > + le16 eol; > + le16 lifetimeA; > + le16 lifetimeB; > +}; > +\end{lstlisting} > + > +The device lifetime metrics \field{eol}, \field{lifetimeA} and > \field{lifetimeB} > +have the semantics described by the JEDEC standard No.84-B50. Is there a more specific way of referencing this? For example, the section of the spec that describes these fields. Are the called "eol", "lifetimeA", "lifetimeB" in the eMMC spec?
Attachment:
signature.asc
Description: PGP signature
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]