Re: [virtio-dev] [PATCH v4] Add lifetime metrics to virtio-blk

[Stefan Hajnoczi <stefanha@redhat.com>]

On Fri, Mar 05, 2021 at 10:27:43AM -0700, Enrico Granata wrote:
> @@ -4754,6 +4779,12 @@ \subsection{Device Operation}\label{sec:Device
> Types / Block Device / Device Ope
>  (case~\ref{item:flush3}).  Failure to do so can cause data loss
>  in case of a crash.
> 
> +If the device is backed by storage providing lifetime metrics (such as eMMC
> +or UFS persistent storage), the device SHOULD offer the VIRTIO_BLK_F_LIFETIME
> +flag. The flag MUST NOT be offered if the device is backed by storage for which
> +the lifetime metrics described in this document cannot be obtained or for which
> +such metrics have no useful meaning.
> +
>  If the driver changes \field{writeback} between the submission of the write
>  and its completion, the write could be either volatile or stable when
>  its completion is reported; in other words, the exact behavior is undefined.

This should probably go at the end of this device normative section
instead of splitting the clauses about write persistence.

Otherwise:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Attachment: signature.asc
Description: PGP signature