Re: [PATCH v3] virtio-pmem: PMEM device spec

[Stefan Hajnoczi <stefanha@redhat.com>]

On Thu, Sep 02, 2021 at 11:18:39AM +0200, Pankaj Gupta wrote:
> > > +Requests have the following format:
> > > +
> > > +\begin{lstlisting}
> > > +struct virtio_pmem_req {
> > > +        le32 type;
> > > +};
> > > +\end{lstlisting}
> > > +
> > > +\field{type} is the request command type.
> >
> > Where are the type constants defined? I was expecting a flush request
> > type constant:
> >
> >   /* Request types */
> >   #define VIRTIO_PMEM_REQ_T_FLUSH 0
> 
> Removed this in current version. Thinking this might be driver specific detail.
> Will add again.

Constant values that the driver places into the "type" field need to be
defined in the specification. Otherwise there's a risk that drivers
place different values into the field and we cannot add new types of
requests in the future.

Stefan

Attachment: signature.asc
Description: PGP signature