OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [PATCH v2] Add device reset timeout field

On Fri, Oct 08 2021, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Fri, Oct 08, 2021 at 10:59:02AM +0000, Parav Pandit wrote:
>> It may be even a pre-boot environment where 100msec or 10msec may be too short interval as other extreme of VM boot time example.
> I don't really know what this means. We are talking about how long
> it takes device to calm down and stop poking at the host
> after it's told to reset. 10ms worst case not enough for this?

To me, that sounded more like a physical device that needs to do
something like boot its firmware before it can perform an actual virtio
operation (and reset simply happens to be the first one.)

So, I'm getting more confused about the scope of this timeout. If it's
more a "device might not be ready yet" issue, I don't think we need a
timeout for reset specifically. Same for races with hotplugging. If it's
about "reset may take some time, because it will take some time before
all operations have quiesced", I don't see how the device can come up
with a value that isn't anything other than a wild guess, and the driver
could do wild guessing equally well.

I feel like I'm missing something.

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]