OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [PATCH v2] Add device reset timeout field

On Mon, Oct 11, 2021 at 03:44:14PM +0000, Parav Pandit wrote:
> > > This is unlikely to work the reset is completed. Because a real device
> > implementing this would prefer to do this in fw for 1000 virtio devices sitting on
> > the physical card.
> > > And it is very much driven by such implementation at device devel.
> > > So it cannot update the counter value if reset is not completed for the device.
> > >
> > > I think read only device reset timeout is most elegant option during device
> > initialization phase that eliminates infinite loop of today.
> > 
> > Why can't a driver just go ahead and do a timeout regardless? 
> o.k. lets consider this thought exercise. What is the timeout value that driver will choose if device doesn't specify one?
> I explained in previous thread and you acked that actual fw based device may take longer to initialize than pure sw implementation backend.
> In second example a pre-boot device can take even longer initialization time.
> Sriov VF device may initialize lot faster.
> Instead of driver having such transport, and device specific checks, (or some very short or very long timeout), we propose, that let device mention such timeout value.

Parav I think you are conflating reset with initialization time.
initialization is just for host boot which takes seconds anyway -
but no, minutes is not reasonable their, either.
reset affects guest boot. This needs to complete in milliseconds.

This conflation is IMHO one of the problems with this proposal.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]