OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [PATCH V5 1/2] virtio: i2c: No need to have separate read-write buffers

On Tue, Oct 12, 2021 at 1:23 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> The virtio I2C protocol allows to contain multiple read-write requests
> in a single I2C transaction using the VIRTIO_I2C_FLAGS_FAIL_NEXT flag,
> where each request contains a header, buffer and status.
> There is no need to pass both read and write buffers in a single
> request, as we have a better way of combining requests into a single I2C
> transaction. Moreover, this also limits the transactions to two buffers,
> one for read operation and one for write. By using
> VIRTIO_I2C_FLAGS_FAIL_NEXT, we don't have any such limits.
> Remove support for multiple buffers within a single request.
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/112
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Thanks for splitting up the two patches, I think this is much clearer now.

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]