OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions

On 13-10-21, 12:07, Jie Deng wrote:
> The "VIRTIO_I2C_FLAGS_M_RD" is consistent with the permissions of the
> buffer.


> When this flag is set, the buffer is also marked as device write -only with


> So if this feature isn't available we can use the the latter. We only need
> this flag when there is no buffer.

Which means that we need to carry extra piece of code for the same
work (with no benefit as it will never happen, everyone will support
this flag as all the implementations are new currently). This is
exactly what we are trying to avoid by making this feature mandatory,
drivers will be expected to set/clear this flag all the time.

We don't want to have code like this anywhere:

if (feature)
        read flag...
        read permissions...


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]