OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH v2] virtio-net: support reset queue


On Mon, 21 Feb 2022 12:27:20 +0800, Jason Wang <jasowang@redhat.com> wrote:
>
> å 2022/2/10 äå7:03, Xuan Zhuo åé:
> > This patch defines some requirements for virtio-net to support reset
> > queues.
> >
> > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > ---
> >   conformance.tex |  1 +
> >   content.tex     | 16 ++++++++++++++++
> >   2 files changed, 17 insertions(+)
> >
> > diff --git a/conformance.tex b/conformance.tex
> > index 42f8537..3656da5 100644
> > --- a/conformance.tex
> > +++ b/conformance.tex
> > @@ -396,6 +396,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Packet Transmission}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Setting Up Receive Buffers}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Processing of Incoming Packets}
> > +\item \ref{devicenormative:Device Types / Network Device / Device Operation / Reset Virtqueue}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Control Virtqueue / Packet Receive Filtering}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Control Virtqueue / Setting MAC Address Filtering}
> >   \item \ref{devicenormative:Device Types / Network Device / Device Operation / Control Virtqueue / Gratuitous Packet Sending}
> > diff --git a/content.tex b/content.tex
> > index c6f116c..63dacb0 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -4000,6 +4000,22 @@ \subsubsection{Processing of Incoming Packets}\label{sec:Device Types / Network
> >   #define VIRTIO_NET_HASH_REPORT_UDPv6_EX        9
> >   \end{lstlisting}
> >
> > +\subsubsection{Reset Virtqueue}\label{sec:Device Types / Network Device / Device Operation / Reset Virtqueue}
> > +
> > +The receive and transmission virtqueues and the control virtqueue can implement
> > +reset based on Virtqueue Reset (See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}).
> > +
> > +\devicenormative{\paragraph}{Gratuitous Packet Sending}{Device Types / Network Device / Device Operation / Reset Virtqueue}
>
>
> s/"Gratuitous Packet Sending"/"Reset Virtqueue"/ ?
>
>
> > +
> > +After automatic receive steering or RSS receive steering has completed the
> > +selection of the queue, if the destination receive queue is in reset state,
> > +the device SHOULD re-select a different random queue.
> > +
> > +After RSS receive steering has completed the selection of the queue, if the
> > +destination receive queue is in reset state, the device can drop the packet.
>
>
> I guess what we really mean is to use "MUST" here? And this paragraph
> (can drop) seems conflict with previous one (SHOULD re-select)?
>
> I wonder if it's better to add stuffs simply in the device normative in
> automatic steering and RSS instead of using a dedicated subsection here.
>

OK.

Thanks.

> Thanks
>
>
> > +
> > +If all receive queues are in reset state, the device can drop the packet.
> > +
> >   \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Device Operation / Control Virtqueue}
> >
> >   The driver uses the control virtqueue (if VIRTIO_NET_F_CTRL_VQ is
>


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]