OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state


> From: Jason Wang <jasowang@redhat.com>
> Sent: Wednesday, April 27, 2022 7:30 AM
> 
> On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit <parav@nvidia.com> wrote:
> >
> > example flow:
> > a) 0,0 -> device init time value
> > b) 1,0 -> vq is enabled by driver and working
> 
> Did you see my reply in V1? What's the reason for using write to clear
> behavior that is different from the device status?
> 
> We can simply make this as 1, 1 here and let the driver write to 0 to reset the
> virtqueue.
> 
> And if we do this, the queue_enable and queue_reset are always the same,
> then we can simply reuse queue_enable.
> 
Yes, I know we can make this work using new feature bit + single queue_enable register.
I replied that in v0 to Michael.

I was not sure how drastic that would be at this point in the spec release cycle that Michael highlighted.
Hence, I proposed a minimal change fix to queue_reset register given timeline.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]