OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state


> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Wednesday, April 27, 2022 8:48 AM

[..]
> > +\field{queue_reset} to reset the queue, driver MUST verify that the
> > +queue
> 
> s/driver/the driver/
> 
Done.

> > +has been reset by reading back \field{queue_reset} until device returns a
> value of 0.
> 
> s/device/the device/
Done.

> 
> > +Device continue to report value of 1 for the \field{queue_reset}
> > +until device finishes the queue reset request.
> 
> This looks a bit odd: Shouldn't that go into the normative section for the
> device instead?
Yes, Michael also had same comment.
I am moving there.

> 
> > When the device completes the queue reset, \field{queue_reset}
> > +and \field{queue_enable} set to zero, indicating that specified queue
> > +is ready to be enabled again.
> 
> Same here. I think a statement that the driver MUST NOT consider queue
> reset to be complete until it reads back 0 in both queue_reset and
> queue_enable is more appropriate here.
> 
This was very useful. I had hard time put the wording as driver centric way.
Thanks a lot.

[..]

> Similar comments as for the pci section.

Fixed.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]