Re: [virtio] Re: [virtio-dev] [PATCH] audio->sound

[Matti MÃll <Matti.Moell@opensynergy.com>]

On 08.09.22 13:09, Michael S. Tsirkin wrote:
> On Thu, Sep 08, 2022 at 11:11:40AM +0200, Cornelia Huck wrote:
> > On Thu, Sep 08 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > Spec calls the device "sound device". Make the name in the
> > > ID section match.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >   content.tex | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/content.tex b/content.tex
> > > index 5c66e6b..279998a 100644
> > > --- a/content.tex
> > > +++ b/content.tex
> > > @@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
> > >   \hline
> > >   24         &   Memory device \\
> > >   \hline
> > > -25         &   Audio device \\
> > > +25         &   Sound device \\
> > >   \hline
> > >   26         &   file system device \\
> > >   \hline
> >
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> >
> > Actually, under the title "Sound device", the spec says
> >
> > "The virtio sound card is a virtual audio device..."
> >
> > -- should it be "virtio sound device" instead?
>
> I don't know, leave that for audio experts ;)

I'll pretend to be one, and as far as I can remember audio is only the 
sounds in the audible range (few Hz to 20kHz) but SOUND can go below and 
above that in frequency (ultrasonic for example). It's an elaborate form 
of bike shedding if you ask me, but the 'real experts(tm)' claim that 
there's a huge difference.

As for the change, it looks fine to me. It makes the naming consistent 
across the chapters and doesn't exclude inaudible tones.

Reviewed-By: Matti MÃll <Matti.Moell@opensynergy.com>

--
OpenSynergy GmbH

Rotherstr. 20, 10245 Berlin

Phone: +49 30 60 98 54 0 â 54

Fax:      +49 30 60 98 54 0 -99

EMail: matti.moell@opensynergy.com

www.opensynergy.com

Handelsregister/Commercial Registry: Amtsgericht Charlottenburg, HRB 108616B

GeschÃftsfÃhrer/Managing Director: Regis Adjamah