[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH v7] virtio-blk: add zoned block device specification
On Sun, Oct 30, 2022 at 11:06:32PM -0400, Dmitry Fomichev wrote: A minor issue about normative vs non-normative sections: > +Devices that offer the VIRTIO_BLK_F_ZONED feature while reporting the > +VIRTIO_BLK_Z_NONE zoned model are drive-managed zoned block devices. In this > +case, the driver should treat the device as a regular non-zoned block device. The VIRTIO spec tries to use should/may/must/etc in the drivernormative and devicenormative sections. The non-normative sections describe the interface without making normative statements. Use of "should" suggests that maybe this should be in a normative section? If you decide not to move it to a normative section then you could simply reword it: "the driver treats the device as a regular ..." > + > +Host-managed zoned block devices have their LBA range divided into Sequential > +Write Required (SWR) zones that require some additional handling from the host > +for correct operation. All write requests to SWR zones must be sequential and There is a "must" here. Same question as above. Aside from that: Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Attachment:
signature.asc
Description: PGP signature
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]