Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Wed, 11 Jan 2023 21:46:37 +0100, Halil Pasic <pasic@linux.ibm.com> wrote:
> On Wed, 11 Jan 2023 19:08:53 +0800
> Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
>
> > > > +\subsection{Permissions}\label{sec:Device Types / Network Device / Device Operation / Permission}
> > > > +
> > > > +The permissions of a ism region determine whether this ism region can be
> > > > +attached and the read and write permissions after attach.
> > > > +
> > > > +The driver can set the default permissions, or set permissions for some certain
> > > > +devices.
> > >
> > > What does "default permissions" and "some certain devices" mean here?
> >
> > "default permissions": This can be understood as the permissions for all devices.
> > "some certain devices": This is the permissions set for a specific device.
>
> This is IMHO to far where you discuss the permission model and make some
> normative statements about it (in 5.20.8.4 Grant ISM Region).

Will fix.

>
> BTW in my opinion that part needs some more work as well. For example if
> the "default" permission is permissive, but the permission specifically
> set for the device attempting the operation it ain't clear what happens.
> I may end up commenting some more on these at when reviewing that part.
>
>

Look forward to your reply.

Thanks.