[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation
On Tue, Apr 04, 2023 at 06:29:25PM +0200, Halil Pasic wrote: > On Thu, 23 Mar 2023 23:24:22 +0800 > Heng Qi <hengqi@linux.alibaba.com> wrote: > > > +struct virtio_net_ctrl_coal_vq { > > + le16 vqn; > > + le16 reserved; > > + struct virtio_net_ctrl_coal coal; > > +}; > > + > > #define VIRTIO_NET_CTRL_NOTF_COAL 6 > > #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0 > > #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1 > > + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2 > > + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3 > > \end{lstlisting} > > > > Coalescing parameters: > > \begin{itemize} > > +\item \field{vqn}: The virtqueue number of an enabled transmit or receive virtqueue. > > Just to be on the safe side: VIRTIO_F_NOTIF_CONFIG_DATA has been > negotiated, and queue_select != queue_notify_data, is vqn supposed > to contain queue_notify_data or the number/index that is used for > queue_select (I'm talking about the PCI transport case)? > > Regards, > Halil I think it's the vq number as it says here, this is not transport specific. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]