[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v12 03/10] admin: introduce group administration commands
On Tue, Apr 25, 2023 at 08:18:54PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Tuesday, April 25, 2023 4:05 PM > > > Ok. I feel it is still worth to have commit log updated. If you happen to revise > > v13, please do. > > > Else its fine. > > > > > > v12 surely doesn't merge cleanly. So v13 is needed anyway. > > > > > > Can you please generate? Patch-5 of v12 fails to apply. > > > > should apply on top of 985bbf397db4228faf3ec464e838687dc4cb4904. master > > will fail because of the file movement. I will need to rebase to apply on latest > > master, I will do it before we start voting. > > Ok. sounds good. I assume you will post rebased v13 with commit log updated? > When do you plan to do? > I request that it is better to rebase now because legacy related patches need to touch the add the PCI extended capability on top of your changes. I can rebase and push to a branch. Day after tomorrow at the earliest due to a holiday. I don't want to repost right now, spamming is not polite to reviewers, several days need to pass. > This results in further manual merges for me. > Better to do the work once with one time rebase, instead of both of us. > > Let me know if I should generate v13 fixing above two items as you have holiday this week. > It helps me build on top of AQ patches with one time rebase. I pushed the rebase to tag mst-admin-v13 on github. Don't have time for tweaks it's a holiday. I usually leave patches on list for a week or so. If no comments I will post v13 and we will roll a vote. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]