Re: [virtio] [PATCHv2] pci: new configuration layout

[Stefan Hajnoczi <stefanha@redhat.com>]

On Wed, Sep 11, 2013 at 06:45:11PM +0300, Michael S. Tsirkin wrote:
> +device_feature_select
> +
> +	Selects which Feature Bits does device_feature field refer to.

Selects which Feature Bits the device_feature field refers to.

> +guest_feature_select
> +
> +	Selects which Feature Bits does guest_feature field refer to.

Selects which Feature Bits the guest_feature field refers to.

> +device_status
> +
> +	Device Status field.

It would be handy to reference "2.1.1. Device Status Field" which
documents the bits.

> +
> +queue_select
> +
> +	Queue Select. Selects which virtqueue do other fields refer to.

Selects which virtqueue other fields refer to.

> +queue_enable
> +
> +	Used to selectively prevent host from executing requests from this virtqueue.
> +	1 - enabled; 0 - disabled

The new text often lacks articles ("the", "a", etc), which is bit too
brief for standards text.  Using full sentences seems to be the style
that the rest of the document is written in.

I haven't pointed out all instances here, but if there is agreement to
stick to full sentences, I will post an edited version.

s/host/the host/

> +100.100.1.2.2. ISR status structure layout
> +-------------------------
> +ISR status structure includes a single 8-bite ISR status field

8-bit

>  2.3.1.3.1. Device Initialization
>  -------------------------------
>  
> +This documents PCI-specific steps executed during Device Initialization.
> +As the first step, driver must detect device configuration layout
> +to locate configuration fields in memory,I/O or configuration space of the

s/,/, /