OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: [OASIS Issue Tracker] Created: (VIRTIO-36) balloon: align val in virtio_balloon_stat

balloon: align val in virtio_balloon_stat

                 Key: VIRTIO-36
                 URL: http://tools.oasis-open.org/issues/browse/VIRTIO-36
             Project: OASIS Virtual I/O Device (VIRTIO) TC
          Issue Type: Improvement
            Reporter: Michael Tsirkin

we have:
        struct virtio_balloon_stat {
        #define VIRTIO_BALLOON_S_SWAP_IN  0
        #define VIRTIO_BALLOON_S_SWAP_OUT 1
        #define VIRTIO_BALLOON_S_MAJFLT   2
        #define VIRTIO_BALLOON_S_MINFLT   3
        #define VIRTIO_BALLOON_S_MEMFREE  4
        #define VIRTIO_BALLOON_S_MEMTOT   5
                u16 tag;
                u64 val;
        } __attribute__((packed));

val is 8 bytes but aligned at a 2 byte boundary.
this is ugly and unusual, and requires implementations
to use packed structures for access, which is error-prone.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://tools.oasis-open.org/issues/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]