Re: [virtio] [PATCH] 2.3.2 MMIO: Upgrade register layout to version 2

[Rusty Russell <rusty@au1.ibm.com>]

Pawel Moll <pawel.moll@arm.com> writes:
> This patch addresses VIRTIO-44:
>
> * Clarifies MagicValue content
> * Bumps up the Version value to 2
> * Removes paged-based addressing and replaces it
>   with 64 bit addresses
> * Replaces implicit queue organisation (based
>   on alignment size) with explicit desc/avail/used
>   addreses (based on original MST's patch, see
>   VIRTIO-41)
> * Introduces explicit protocol for queue
>   enabling (based on original MST's idea)
>   and disabling
> * Introduces config space versioning (based on
>   Rusty's original patch, see VIRTIO-35)
>
> Most of the changes are closely related to
> each other, but I can try to split at least
> the VIRTIO-35 stuff into a separate patch...
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

It's not too bad all together, though always nice to split into separate
patches.  There's some whitespace and renumbering noise which would be
nice as a separate patch...

But I'm a bit surprised that you didn't add a legacy section?
Pretending MMIO v1 doesn't exist at all is going a bit far :)

Cheers,
Rusty.