OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [PATCH] 4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order


The order of the fields in the legacy PCI header seems to get
messed up in the new spec, with the "Queue Address" moved
behind "Queue Notify". According to the 0.9.5 version of the spec
it should be:

* Device Features 32
* Driver Features 32
* Queue Address 32
* Queue Size 16
* Queue Select 16
* Queue Notify 16
* Device Status 8
* ISR Status 8

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---

Reported by a colleague implementing a PCI device - it's got to
be a copy-and-paste error. The Linux kernel driver definitely
agrees with the 0.9.5 layout...

 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 5b11477..b1db063 100644
--- a/content.tex
+++ b/content.tex
@@ -959,7 +959,7 @@ When used through the legacy interface, the virtio header looks as follows:
  Read / Write & R & R+W & R+W & R & R+W & R+W & R+W & R \\
 \hline
  Purpose & Device Features bits 0:31 & Driver Features bits 0:31 &
-  Queue Size & Queue Select & Queue Notify & Queue Address &
+  Queue Address & Queue Size & Queue Select & Queue Notify &
   Device Status & ISR \newline Status \\
 \hline
 \end{tabularx}
-- 
1.8.3.2



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]