Re: [virtio-dev] [PATCH 1/1] Clarify padding in structures

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Fri, 07 Feb 2014 14:09:42 +1030
Rusty Russell <rusty@au1.ibm.com> wrote:

> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> > Explicitly specify that our C struct specifications are without padding,
> > and add some definitions for our integer data types. Also note what the
> > __packed__ annotation signifies.
> >
> > Remove __packed__ annotation from all ccw structures that don't need it,
> > and make the length requirements explicit for those that do.
> >
> > This resolves VIRTIO-56.
> >
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Please also remove the following from content.tex.  It's now doubly redundant :)
> 
> Thanks!
> Rusty.
> 
> diff --git a/content.tex b/content.tex
> index 48c2d8e..da6e6f8 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -12,9 +12,6 @@ device consists of the following parts:
>  \item One or more virtqueues
>  \end{itemize}
> 
> -Unless explicitly specified otherwise, all multi-byte fields are little-endian.
> -To reinforce this the examples use typenames like "le16" instead of "uint16_t".
> -
>  \section{Device Status Field}\label{sec:Basic Facilities of a Virtio Device / Device Status Field}
> 
>  The driver MUST update the Device Status field in the order below to

Indeed. I've folded this hunk into my patch.