OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [PATCH 3/3] drop /* LEGACY version was not little endian */


Two issues with the comment:
	- it mixes legacy documentation in main part of the spec
	- it says what format isn't instead of what it is
Now that we have documented that LE can mean
legacy endian, there's no need for the comment.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 content.tex | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/content.tex b/content.tex
index 61d3c2b..b5e10a0 100644
--- a/content.tex
+++ b/content.tex
@@ -349,7 +349,6 @@ Drivers MUST NOT add a descriptor chain over than $2^{32}$ bytes long in total;
 this implies that loops in the descriptor chain are forbidden!
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct vring_desc {
         /* Address (guest-physical). */
         le64 addr;
@@ -410,7 +409,6 @@ the device MUST ignore the write-only flag (\field{flags}\&VRING_DESC_F_WRITE) i
 \subsection{The Virtqueue Available Ring}\label{sec:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Available Ring}
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct vring_avail {
 #define VRING_AVAIL_F_NO_INTERRUPT      1
         le16 flags;
@@ -447,7 +445,6 @@ entirely.
 \subsection{The Virtqueue Used Ring}\label{sec:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Used Ring}
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct vring_used {
 #define VRING_USED_F_NO_NOTIFY  1
         le16 flags;
@@ -456,7 +453,6 @@ struct vring_used {
         le16 avail_event; /* Only if VIRTIO_RING_F_EVENT_IDX */
 };
 
-/* Note: LEGACY version was not little endian! */
 /* le32 is used here for ids for padding reasons. */
 struct vring_used_elem {
         /* Index of start of used descriptor chain. */
@@ -2570,7 +2566,6 @@ and transmitq0..transmitqN respectively;
 is negotiated.  Legal values for this field are 1 to 0x8000.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_net_config {
         u8 mac[6];
         le16 status;
@@ -2657,7 +2652,6 @@ placed in the receiveq0..receiveqN. In each case, the packet
 itself is preceeded by a header:
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_net_hdr {
 #define VIRTIO_NET_HDR_F_NEEDS_CSUM    1
         u8 flags;
@@ -2985,7 +2979,6 @@ queue incoming packets into one of the multiple receiveq0..receiveqN
 depending on the packet flow.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_net_ctrl_mq {
         le16 virtqueue_pairs;
 };
@@ -3122,7 +3115,6 @@ present. The availability of the others all depend on various feature
 bits as indicated above.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_blk_config {
         le64 capacity;
         le32 size_max;
@@ -3381,7 +3373,6 @@ only exist if VIRTIO_CONSOLE_F_MULTIPORT is set.
   acknowledging the feature.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_console_config {
         le16 cols;
         le16 rows;
@@ -3458,7 +3449,6 @@ control sendq for driver-to-device messages.  The layout of the
 control messages is:
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_console_control {
         le32 id;    /* Port number */
         le16 event; /* The kind of control event */
@@ -3679,7 +3669,6 @@ as follows:
   compatibility, unsupported statistics should be omitted.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_balloon_stat {
 #define VIRTIO_BALLOON_S_SWAP_IN  0
 #define VIRTIO_BALLOON_S_SWAP_OUT 1
@@ -3771,7 +3760,6 @@ targets that receive and process the requests.
   and \field{cdb_size} are writable by the driver.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_scsi_config {
         le32 num_queues;
         le32 seg_max;
@@ -3856,7 +3844,6 @@ consumed with no order constraints.
 Requests have the following format:
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_scsi_req_cmd {
         // Device-readable part
         u8 lun[8];
@@ -4018,7 +4005,6 @@ The following commands are defined:
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK           6
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET       7
 
-/* Note: LEGACY version was not little endian! */
 struct virtio_scsi_ctrl_tmf
 {
         // Device-readable part
-- 
MST



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]