OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [PATCH 1/2] VIRTIO-28: Deprecate balloon device, add number for new one.


Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
---
 content.tex | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/content.tex b/content.tex
index 6b7dfdc..0e264f5 100644
--- a/content.tex
+++ b/content.tex
@@ -2655,7 +2655,7 @@ Device ID  &  Virtio Device    \\
 \hline
 4          &  entropy source    \\
 \hline
-5          & memory ballooning  \\
+5          & memory ballooning (legacy)  \\
 \hline
 6          &     ioMemory       \\
 \hline
@@ -2671,6 +2671,8 @@ Device ID  &  Virtio Device    \\
 \hline
 12         &   virtio CAIF      \\
 \hline
+13         &  memory balloon    \\
+\hline
 16         &   GPU device       \\
 \hline
 \end{tabular}
@@ -3909,7 +3911,12 @@ how many random bytes were received.
 The device MUST place one or more random bytes into the buffer, but it
 MAY use less than the entire buffer length.
 
-\section{Memory Balloon Device}\label{sec:Device Types / Memory Balloon Device}
+\section{Legacy Interface: Memory Balloon Device}\label{sec:Device Types / Memory Balloon Device}
+
+This device is deprecated, and thus only exists as a legacy device
+illustrated here for reference.  The device number 13 is reserved for
+a new memory balloon interface which is expected in a future version
+of the standard.
 
 The virtio memory balloon device is a primitive device for
 managing guest memory: the device asks for a certain amount of
@@ -3951,7 +3958,6 @@ struct virtio_balloon_config {
 };
 \end{lstlisting}
 
-\subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Memory Balloon Device / Device configuration layout / Legacy Interface: Device configuration layout}
 Note that these fields are always little endian, despite convention
 that legacy device fields are guest endian.
 
@@ -4044,7 +4050,6 @@ as follows:
   compatibility, unsupported statistics should be omitted.
 
 \begin{lstlisting}
-/* Note: LEGACY version was not little endian! */
 struct virtio_balloon_stat {
 #define VIRTIO_BALLOON_S_SWAP_IN  0
 #define VIRTIO_BALLOON_S_SWAP_OUT 1
@@ -4052,16 +4057,11 @@ struct virtio_balloon_stat {
 #define VIRTIO_BALLOON_S_MINFLT   3
 #define VIRTIO_BALLOON_S_MEMFREE  4
 #define VIRTIO_BALLOON_S_MEMTOT   5
-        le16 tag;
-        le64 val;
+        u16 tag;
+        u64 val;
 } __attribute__((packed));
 \end{lstlisting}
 
-\paragraph{Legacy Interface: Memory Statistics}\label{sec:Device Types / Memory Balloon Device / Device Operation / Memory Statistics / Legacy Interface: Memory Statistics}
-For legacy devices, the fields in struct virtio_balloon_stat are the
-native endian of the guest rather than (necessarily) little-endian.
-
-
 \subsubsection{Memory Statistics Tags}\label{sec:Device Types / Memory Balloon Device / Device Operation / Memory Statistics Tags}
 
 \begin{description}
-- 
1.8.3.2



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]