OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [OASIS Issue Tracker] (VIRTIO-54) 4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields


     [ https://tools.oasis-open.org/issues/browse/VIRTIO-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Tsirkin updated VIRTIO-54:
----------------------------------

      Proposal: 
Fixed in the following patch: https://www.oasis-open.org/apps/org/workgroup/virtio/email/archives/201401/msg00055.html

4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order

The order of the fields in the legacy PCI header seems to get
messed up in the new spec, with the "Queue Address" moved
behind "Queue Notify". According to the 0.9.5 version of the spec
it should be:

* Device Features 32
* Driver Features 32
* Queue Address 32
* Queue Size 16
* Queue Select 16
* Queue Notify 16
* Device Status 8
* ISR Status 8

Signed-off-by: Pawel Moll <pawel.moll@arm.com>


  was:Fixed in the following patch: https://www.oasis-open.org/apps/org/workgroup/virtio/email/archives/201401/msg00055.html

    Resolution: 
applied in r198 | hornet | 2014-01-29 11:13:24 +0000 (Wed, 29 Jan 2014) | 21 lines
approved 11 February 2014


  was:
r198 | hornet | 2014-01-29 11:13:24 +0000 (Wed, 29 Jan 2014) | 21 lines

4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order

The order of the fields in the legacy PCI header seems to get
messed up in the new spec, with the "Queue Address" moved
behind "Queue Notify". According to the 0.9.5 version of the spec
it should be:

* Device Features 32
* Driver Features 32
* Queue Address 32
* Queue Size 16
* Queue Select 16
* Queue Notify 16
* Device Status 8
* ISR Status 8

Signed-off-by: Pawel Moll <pawel.moll@arm.com>



> 4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields
> ---------------------------------------------------------
>
>                 Key: VIRTIO-54
>                 URL: https://tools.oasis-open.org/issues/browse/VIRTIO-54
>             Project: OASIS Virtual I/O Device (VIRTIO) TC
>          Issue Type: Bug
>            Reporter: Pawel Moll
>            Assignee: Pawel Moll
>
> The order of the fields in the legacy PCI header seems to get messed up in the new spec, with p. 4.1.2.5 "Legacy Interfaces: A Note on PCI Device Layout" saying:
> * Device Features 32
> * Driver Features 32
> * Queue Size 32   <-------------- !!!
> * Queue Select 16
> * Queue Notify 16
> * Queue Address 16 <------------ !!!
> * Device Status 8
> * ISR Status 8
> According to the 0.9.5 version of the spec it should be:
> * Device Features 32
> * Driver Features 32
> * Queue Address 32
> * Queue Size 16
> * Queue Select 16
> * Queue Notify 16
> * Device Status 8
> * ISR Status 8



--
This message was sent by Atlassian JIRA
(v6.1.1#6155)


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]