[OASIS Issue Tracker] (VIRTIO-130) 4.1.4.5 ISR status capability diagram incorrect

[OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org>]

     [ https://issues.oasis-open.org/browse/VIRTIO-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Tsirkin updated VIRTIO-130:
-----------------------------------

    Environment: Rusty Russell <rusty@rustcorp.com.au>
     Resolution: r487

approved: https://www.oasis-open.org/apps/org/workgroup/virtio/ballot.php?id=2771


> 4.1.4.5 ISR status capability diagram incorrect
> -----------------------------------------------
>
>                 Key: VIRTIO-130
>                 URL: https://issues.oasis-open.org/browse/VIRTIO-130
>             Project: OASIS Virtual I/O Device (VIRTIO) TC
>          Issue Type: Bug
>    Affects Versions: virtio 1.0 cs01, virtio 1.0 cs02
>         Environment: Rusty Russell <rusty@rustcorp.com.au>
>            Reporter: Rusty Russell
>             Fix For: virtio 1.0 cs03
>
>
> 4.1.4.5 ISR status capability diagram has the "Device Configuration Interrupt " as bit 0, and the "Queue Interrupt" as bit 1.  This is the wrong way around: it disagrees with the legacy implementations, as well as the spec elsewhere:
> 4.1.5.3 Virtqueue Interrupts From The Device
> If an interrupt is necessary for a virtqueue, the device would typically act as follows:
>     If MSI-X capability is disabled:
>         Set the lower bit of the ISR Status field for the device.
>         
> ...
> 4.1.5.4 Notification of Device Configuration Changes
> Some virtio PCI devices can change the device configuration state, as reflected in the device-specific configuration region of the device. In this case:
>     If MSI-X capability is disabled:
>         Set the second lower bit of the ISR Status field for the device. 
> ...



--
This message was sent by Atlassian JIRA
(v6.2.2#6258)