Re: [virtio-comment] Comments on Virtio 1.0 cs03

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Jan 11, 2016 at 02:54:14PM +0800, Kevin Lo wrote:
> Hi,
> 
> After reading the specification, I have two minor comments.
> 
> First, sort device status field [1] in the section 2.1 to improve readability,
> namely ACKNOWLEDGE (1), DRIVER (2), DRIVER_OK (4), FEATURES_OK (8),
> DEVICE_NEEDS_RESET (64), FAILED (128).

The order is inconsistent, but I think it's more important to
list them in the order they are set, since we say above it:
	The \field{device status} field provides a simple low-level
	indication of the completed steps of this sequence.

So a better order is ACKNOWLEDGE, DRIVER, FEATURES_OK, DRIVER_OK,
FAILED, DEVICE_NEEDS_RESET since need reset would typically
be set only on error after DRIVER_OK.

I'll send a patch that does this.

> Second, since vring* and VRING* have been replaced with virtq* and VIRTQ*
> respectively, I suggesting renaming the header virtio_ring.h to virtio_queue.h
> or fixing include guards to match the name of the header.

Good idea.

> [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs03/virtio-v1.0-cs03.html#x1-90001
> 
> Thanks,
> Kevin
> 
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
> 
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
> 
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/