Re: [virtio-dev] [PATCH 1/6] notifications: unify notifications wording in core

[Stefan Hajnoczi <stefanha@redhat.com>]

On Mon, May 14, 2018 at 09:40:43PM +0200, Halil Pasic wrote:
> On 05/14/2018 06:36 PM, Stefan Hajnoczi wrote:
> > On Thu, Apr 26, 2018 at 12:59:57PM +0200, Halil Pasic wrote:
> > > @@ -235,12 +236,13 @@ transmit and one for receive.}.
> > >   Driver makes requests available to device by adding
> > >   an available buffer to the queue - i.e. adding a buffer
> > >   describing the request to a virtqueue, and optionally triggering
> > > -a driver event - i.e. sending a notification to the device.
> > > +a driver event - i.e. sending an available buffer notification
> > > +to the device.
> > >   Device executes the requests and - when complete - adds
> > >   a used buffer to the queue - i.e. lets the driver
> > >   know by marking the buffer as used. Device can then trigger
> > > -a device event - i.e. send an interrupt to the driver.
> > > +a device event - i.e. send an used buffer notification to the driver.
> > 
> > I would say "a used buffer notification".  "A" vs "an" depends on the
> > sound of the initial syllable, not the spelling.  So "a used car" vs "an
> > upper body".
> > 
> > There are several instances of this in this patch.
> > 
> 
> Right. Will try to hunt all of them down.

I noticed other patches with hunks like this:

 ... an
-interrupt ...
+used buffer notification ...

So there are cases that are harder to find due to line-wrapping.  It
should be easy to find them with a Ctrl+F "an used" search in the HTML
version of the document though, or with a multi-line regular expression.

Attachment: signature.asc
Description: PGP signature