Re: [virtio] [PATCH 2/4] virtio-blk: clarify what seg_max and size_max are for

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Sep 10, 2018 at 10:35:43AM +0200, Paolo Bonzini wrote:
> On 28/08/2018 16:00, Michael S. Tsirkin wrote:
> >> +\item[VIRTIO_BLK_F_SEG_MAX (2)] Maximum number of descriptors in the
> >> +    data portion of a request ("segments") is in \field{seg_max}.
> >>  
> >>  \item[VIRTIO_BLK_F_GEOMETRY (4)] Disk-style geometry specified in
> >>      \field{geometry}.
> > So it's a bit of a mess. For example when you count descriptors with an
> > indirect descriptor you don't count the pointer. Split and packed ring
> > terminology also differ.  We need to have a definition in the common
> > part. Up to cleaning this up?
> 
> Sure, but can it be done as a follow-up?
> 
> Thanks,
> 
> Paolo

Well I'm just not sure this patch clarifies anything as is.

-- 
MST