OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio] [PATCH] block: drop duplicate text


On Mon, Mar 18, 2019 at 06:54:37PM -0400, Michael S. Tsirkin wrote:
> In version 1.1 draft 01 - Section 5.2.6.4 - second bullet:
> 
> Duplicated text "errors, data_len, sense_len and residual MUST reside in
> a single, separate device-writable descriptor" appears +both in the
> beginning and at the end of the 2nd sentence.
> 
> The original text:
> 
> For SCSI commands there are additional constraints. errors, data_len,
> sense_len and residual MUST reside in a single, separate device-writable
> descriptor, sense MUST reside in a single separate device-writable
> descriptor of size 96 bytes, and errors, data_len, sense_len and
> residual MUST reside a single separate device-writable descriptor.
> I suggest to delete the 1st one, so in the end result, fields are
> described in same order as appear in struct virtio_scsi_pc_req.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/39
> Reported-by: Gil Savir <gil.savir@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  content.tex | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Attachment: signature.asc
Description: PGP signature



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]