[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: [OASIS Issue Tracker] (VIRTIO-181) virtio_blk_req.data size - Section 5.2.6 - version 1.1 draft 01
[ https://issues.oasis-open.org/browse/VIRTIO-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael S. Tsirkin updated VIRTIO-181: -------------------------------------- Resolution: This is a duplicate report that was resolved as part of resolution of https://github.com/oasis-tcs/virtio-spec/issues/32 bef3ff7 virtio-blk: document data[] size constraints was: This is a duplicate report that was resolved as part of resolution of https://github.com/oasis-tcs/virtio-spec/issues/34 bef3ff7 virtio-blk: document data[] size constraints > virtio_blk_req.data size - Section 5.2.6 - version 1.1 draft 01 > --------------------------------------------------------------- > > Key: VIRTIO-181 > URL: https://issues.oasis-open.org/browse/VIRTIO-181 > Project: OASIS Virtual I/O Device (VIRTIO) TC > Issue Type: Bug > Affects Versions: virtio 1.1 csprd01 > Environment: "Savir, Gil" <gil.savir@intel.com> > Reporter: Michael S. Tsirkin > Priority: Major > Fix For: virtio 1.1 cs01 > > > In version 1.1 draft 01 - Section 5.2.6 - struct virtio_blk_req definition: > Data field is defined as array of 512 Byte entries as follows: > u8 data[][512]; > It makes sense for IN and OUT requests, since defined for read/write sizes that are 512 Bytes multiplication. > However, it is confusing when used for DISCARD or WRITE_ZEROES requests, since virtio_blk_discard_write_zeroes struct size is 16 > +Bytes. > Is implying that DISCARD and WRITE_ZEROES requests must use data-field sizes that are 512 Bytes multiplication as well? > If yes, than the device can't tell how many virtio_blk_discard_write_zeroes structs reside within data-field. In that case - > +indication for number of virtio_blk_discard_write_zeroes structs needs to be added. -- This message was sent by Atlassian JIRA (v7.7.2#77003)
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]