Re: [virtio] [PATCH v2 06/17] charter: drop attempts to list all devices

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Feb 08, 2021 at 05:15:55PM +0100, Halil Pasic wrote:
> On Mon, 8 Feb 2021 07:15:57 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > we are adding new device types all the time.
> > no point in trying to list them all in the charter.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >  charter.html | 17 +----------------
> >  1 file changed, 1 insertion(+), 16 deletions(-)
> > 
> > diff --git a/charter.html b/charter.html
> > index 38cad98..82fb981 100644
> > --- a/charter.html
> > +++ b/charter.html
> > @@ -80,22 +80,7 @@
> >            Specification of device-specific configuration.
> >            <ol class="vanilla-lower-alpha">
> >              <li>
> > -              For network devices.
> > -            </li>
> > -            <li>
> > -              For block storage devices.
> > -            </li>
> > -            <li>
> > -              For entropy devices.
> > -            </li>
> > -            <li>
> > -              For console devices.
> > -            </li>
> > -            <li>
> > -              For memory ballooning devices.
> > -            </li>
> > -            <li>
> > -              For SCSI endpoint devices.
> > +              Normative requirements for specified device types.
> >              </li>
> 
> Does it make sense to keep the list with only a single element?
> 
> >              <li>
> >                Non-normative advice for designing new device types.
> 
> I believe the the rest of the items starting with the one immediately
> above should be moved up one level higher. These don't seem to be sub
> deliverables of 'device-specific configuration' but top level
> deliverables...

Well if you look at the spec they are all under section
5 Device Types. The only exception is
Appendix B. Creating New Device Types.
I will move that one out.


> Regards,
> Halil