[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved
On Thu, Mar 02, 2023 at 06:40:55PM +0000, Parav Pandit wrote: > Did you miss reviewed-by from [1] or this is an old series reposted? > [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00242.html As a general rule, we don't strictly need to track reviewed by since there's a ballot (and presumably people review before voting). People also tack on Signed-off-by: (and I do it too) but as long as we don't document what it means it's kind of vague, and the process of subscribing to the mailing list is a kind of replacement. If you think everyone needs to follow practices like netdev does, we really need something written up, and agree on it. E.g. I work on the linux kernel too, so I can copy practices from there, but even linux isn't uniform. And I wonder whether it's worth it - it definitely makes contributing to Linux harder, and even within Linux it pushes contributors away. At least for Linux tracking history in a precise way is extremely important since it's helpful with stability. Spec is very different. Until we have a good contribution documentation I think we should not ask people to follow a pseudo linux work flow with requests like "please split this patchset up" or "track changes across patch versions" simply because there's no good docs to teach people what exactly is the best practice. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]